cephx changes for provider-client #3899
Conversation
These funcs allow user to check the kernel support on ocp cluster Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
add cephClientCephX to storageconsumer spec and add kernelVersion in client status Signed-off-by: Rohan Gupta <rohgupta@redhat.com>
if kernel version is supported then increment csiCephUserCurrentGen Signed-off-by: Rohan Gupta <rohgupta@redhat.com>
client sends kernel version in reportStatusRequest, and ReportStatus updates storageConsumer.status.clientStatus.kernelVersion and desiredClientConfigHash. Signed-off-by: Rohan Gupta <rohgupta@redhat.com>
Signed-off-by: Rohan Gupta <rohgupta@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohan47 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
| ) | ||
|
|
||
| var ( | ||
| csiCephUserCurrGen int64 = csiCephUserCurrGenDefault |
There was a problem hiding this comment.
This is a package level variable. All the consumers would use it. Shouldn't this be a local variable?
|
|
||
| if isPrimaryConsumer { | ||
| kernelVersion := r.storageConsumer.Status.Client.KernelVersion | ||
| if supported, err := ocscontrollersutil.IsKernelVersionSupported(kernelVersion, ocscontrollersutil.CephxKeyRotaionKernelSupportVersion); supported && err == nil { |
| } | ||
|
|
||
| var ( | ||
| CephxKeyRotaionKernelSupportVersion = kernelSupportVersion{ |
There was a problem hiding this comment.
| CephxKeyRotaionKernelSupportVersion = kernelSupportVersion{ | |
| CephxKeyRotationKernelSupportVersion = kernelSupportVersion{ |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
Bot
added
the
needs-rebase
3 participants
This PR adds changes to storageconsumer api to inclde cephxConfiguraion in spec and kernel version in storageConsumer.status.clientStatus.kernelVersion.
storageConsumer reconciler increments csiCephUserCurrentGen which triggers creation of new secrets
The provider server api is updated to allow exchange of kernel version from storageClient to provider and send cephclient secret to storageClient.
Not covered in the PR:
Delete old secrets, as they are required by the existing application pods.