DFBUGS-4178:[release-4.18] update go version to resolve CVE issues

[yati1998]

odf4/ocs-metrics-exporter-rhel9: Postgres Scan
Race Condition, fix for this was added from
go 1.23 onwards and go 1.24 being used in main
branch, updating the go version.

ref: https://go-review.googlesource.com/c/go/+/693616

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yati1998
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@yati1998: This pull request references [Jira Issue DFBUGS-4178](https://issues.redhat.com//browse/DFBUGS-4178), which is invalid:

• expected the bug to target the "odf-4.18.15" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

odf4/ocs-metrics-exporter-rhel9: Postgres Scan
Race Condition, fix for this was added from
go 1.23 onwards and go 1.24 being used in main
branch, updating the go version.

ref: https://go-review.googlesource.com/c/go/+/693616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yati1998]

@weirdwiz please do review

[yati1998]

cc @iamniting

[iamniting]

@yati1998 Can you pls look at failures?

[aruniiird]

Can you check these go.mod files,
api/go.mod
services/provider/api/go.mod

When searched for the older go version (1.22), there are couple of docker files (Dockerfile) as well, we may have to update them as well.
./Dockerfile
./metrics/Dockerfile

In the main (master) branch, I could see that our CI yaml file, .github/workflows/ocs-operator-ci.yaml also has been updated (to the matching go version). Since we are updating in 4.18, we can also update this branch's yaml file.

We may have to update the deps as well, by running
go mod tidy
go mod vendor
PS: we may have to run this (tidy) command in the directories where ever we have the go.mod file (which we changed)

After resolving any conflict, make sure we run make build to make sure ocs-operator binaries are built without any errors.

[yati1998]

@aruniiird I have added the changes as per your suggestion, please have a look:

ypadia:ocs-operator$ make build
Running deps-update
go mod tidy && go mod vendor
Running deps-update on api submodule
cd api && go mod tidy && go mod vendor
Running deps-update on metrics submodule
cd metrics && go mod tidy && go mod vendor
Running deps-update on provider/api submodule
cd services/provider/api && go mod tidy && go mod vendor
Using existing controller-gen@v0.17.1 at /home/ypadia/Projects/ocs-operator/bin/controller-gen
Updating generated code
/home/ypadia/Projects/ocs-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
Generating protobuf files for gRPC services
hack/gen-protobuf.sh
protoc already present at /home/ypadia/Projects/ocs-operator/bin/grpc/protoc
protoc-gen-go already present at /home/ypadia/Projects/ocs-operator/bin/grpc/protoc-gen-go
protoc-gen-go-grpc already present at /home/ypadia/Projects/ocs-operator/bin/grpc/protoc-gen-go-grpc

@iamniting please take a look as well

[iamniting]

@yati1998 Can you pls update the vendor and APIs. You can take a look at any of the older Go version update PR's to get a good idea about it.

Though i am not in favour of bumping the go version in the z-stream. It will require a good ammount of changes and testing.

[openshift-ci]

@yati1998: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocs-operator-bundle-e2e-aws	5f2ef05	link	true	/test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.