Skip to content

Disable ocs-metrics-exporter and blackbox exporter for external mode #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ezio-auditore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable ocs-metrics-exporter and blackbox exporter for external mode #3663

ezio-auditore wants to merge 1 commit into from
+11 −8

Conversation

@ezio-auditore
Copy link
Contributor

@ezio-auditore ezio-auditore commented Jan 19, 2026

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ezio-auditore
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weirdwiz
Copy link
Contributor

weirdwiz commented Jan 19, 2026

lgtm

@ezio-auditore
Copy link
Contributor Author

ezio-auditore commented Jan 19, 2026

/test ocs-operator-bundle-e2e-aws

malayparida2000
malayparida2000 reviewed Jan 22, 2026
View reviewed changes
Disable ocs-metrics-exporter and blackbox exporter for external mode
eed6f31 
Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
malayparida2000
malayparida2000 reviewed Jan 22, 2026
View reviewed changes
controllers/storagecluster/reconcile.go
}
// ocs-metrics exporter and black box exporter
// should not be deployed in external mode
if !instance.Spec.ExternalStorage.Enable {
Copy link
Contributor

@malayparida2000 malayparida2000 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weirdwiz is ocs-metrics-exporter necessary in external mode? I am not sure about it.

Also, apart from functionality, I am sure DS Build/QE CI runs would be expecting metrics-exporter deployment to be present. We might need CI change as well before we are able to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malayparida2000 malayparida2000 malayparida2000 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezio-auditore @weirdwiz @malayparida2000