metrics: fix lock contention during PV cache refresh #3654
+111
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weirdwiz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
@aruniiird @SanjalKatiyar Can you pls take a look? |
Move slow Ceph CLI operations outside mutex lock to prevent blocking metric collectors during cache refresh. Previously the lock was held for up to 3 minutes with 100+ PVs, causing /metrics endpoint timeouts. Fixes: https://issues.redhat.com/browse/DFBUGS-4988 Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/metricsendpoint timeoutsAdd()andResync()to prepare data outside lock, then apply atomicallyFixes: https://issues.redhat.com/browse/DFBUGS-4988