add unit test for blackbox exporter #3638
Conversation
this commit adds unit test for blackbox exporter Signed-off-by: yati1998 <ypadia@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yati1998 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@malayparida2000 @weirdwiz please take sometime to review the PR |
| ocsv1 "github.com/red-hat-storage/ocs-operator/api/v4/v1" | ||
| "github.com/red-hat-storage/ocs-operator/v4/controllers/defaults" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
I believe assert can be used instead of require, Can you pls check it once. If assert works import of new package will be ignored.
| "testing" | ||
|
|
||
| securityv1 "github.com/openshift/api/security/v1" | ||
| fakeclientset "github.com/openshift/client-go/security/clientset/versioned/fake" |
There was a problem hiding this comment.
Can you check if this can be ignored and some other package which we are using already can be used?
2 participants
this commit adds unit test for blackbox
exporter