Skip to content

remove spec.hostNetwork field, use spec.network.hostNetwork instead #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OdedViner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove spec.hostNetwork field, use spec.network.hostNetwork instead #3637

OdedViner wants to merge 1 commit into from
+16 −61

Conversation

@OdedViner
Copy link
Contributor

@OdedViner OdedViner commented Dec 21, 2025 •
edited
Loading

remove the deprecated spec.hostNetwork field from
storageclusterspec and update all code to use
spec.network.hostNetwork instead.

changes:

  • removed hostnetwork field from storageclusterspec
  • removed backward compatibility code in getnetworkspec
  • updated getproviderapiserver service to use spec.network.hostnetwork
  • updated test cases to remove backward compatibility tests
  • updated comment to reference network.hostnetwork

this aligns with the rook ceph networkspec structure where hostnetwork is part of the network configuration.

Issue: https://issues.redhat.com/browse/DFBUGS-4528

@rewantsoni
Copy link
Member

rewantsoni commented Dec 22, 2025

/hold

We shouldn't be removing both field and usage together. This way the upper layer will break.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2025
@OdedViner OdedViner force-pushed the deprecate_hostNetwork_param branch from 25e7a43 to 39b8043 Compare December 22, 2025 09:54
@OdedViner
Copy link
Contributor Author

OdedViner commented Dec 22, 2025

/hold

We shouldn't be removing both field and usage together. This way the upper layer will break.

@rewantsoni Based on your comment, I only removed the usage of spec.hostNetwork in the code, but the spec.hostNetwork parameter itself was not deleted.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, OdedViner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2025
@iamniting
Copy link
Member

iamniting commented Dec 23, 2025

/hold

We shouldn't be removing both field and usage together. This way the upper layer will break.

@rewantsoni Are you talking about the Fusion as layer on top or the assisted installer?

@rewantsoni
Copy link
Member

rewantsoni commented Jan 5, 2026

@iamniting Yes, I am talking about Fusion or any other customer-owned automation. We should allow them time to adapt to the newer field

@iamniting
Copy link
Member

iamniting commented Jan 5, 2026

@OdedViner We can merge it in the next release.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2026
@OdedViner
remove spec.hostNetwork field, use spec.network.hostNetwork instead
bbece0d 
remove the deprecated spec.hostNetwork field from
storageclusterspec and update all code to use
spec.network.hostNetwork instead.

changes:
- removed hostnetwork field from storageclusterspec
- removed backward compatibility code in getnetworkspec
- updated getproviderapiserver service to use
  spec.network.hostnetwork
- updated test cases to remove backward compatibility
  tests
- updated comment to reference network.hostnetwork

this aligns with the rook ceph networkspec structure
where hostnetwork is part of the network configuration.

Signed-off-by: Oded Viner <oviner@redhat.com>
@OdedViner OdedViner force-pushed the deprecate_hostNetwork_param branch from 39b8043 to bbece0d Compare January 20, 2026 13:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamniting iamniting iamniting approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@iamniting iamniting

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OdedViner @rewantsoni @iamniting @openshift-merge-robot