Skip to content

Conversation

@yati1998
Copy link
Member

@yati1998 yati1998 commented Sep 5, 2025

Replace removed kube-rbac-proxy sidecars with native secure metrics
using Kubernetes authentication and authorization.

All metrics endpoints are now secured without depending on
gcr.io/kubebuilder/kube-rbac-proxy, which is now deprecated .

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yati1998
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weirdwiz
Copy link
Contributor

weirdwiz commented Sep 8, 2025

If we're just removing kube-rbac-proxy, how're we encrypting the metrics now?

@ShravaniVangur
Copy link
Contributor

Replace removed kube-rbac-proxy sidecars with native secure metrics
using Kubernetes authentication and authorization.

Isn't the implemention of FilterProvider missing?

@yati1998
Copy link
Member Author

yati1998 commented Sep 8, 2025

If we're just removing kube-rbac-proxy, how're we encrypting the metrics now?

yes, other commit is on progress, posted this for initial level review

This commit removes the kube-rc-proxy container and related
usage from the deployment as it has been deprecated.

Signed-off-by: yati1998 <ypadia@redhat.com>
this commit adds the generated changes and also
uses authentication provided by controller-runtime
instead of kube-rbac-proxy

Signed-off-by: yati1998 <ypadia@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@yati1998: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images f86cf12 link true /test images
ci/prow/ci-bundle-ocs-operator-bundle f86cf12 link true /test ci-bundle-ocs-operator-bundle
ci/prow/ocs-operator-bundle-e2e-aws f86cf12 link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants