-
Notifications
You must be signed in to change notification settings - Fork 189
remove kube-rbac-proxy container from deployment #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yati1998 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
If we're just removing |
Isn't the implemention of |
yes, other commit is on progress, posted this for initial level review |
This commit removes the kube-rc-proxy container and related usage from the deployment as it has been deprecated. Signed-off-by: yati1998 <ypadia@redhat.com>
this commit adds the generated changes and also uses authentication provided by controller-runtime instead of kube-rbac-proxy Signed-off-by: yati1998 <ypadia@redhat.com>
faebd0e to
f86cf12
Compare
|
@yati1998: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Replace removed kube-rbac-proxy sidecars with native secure metrics
using Kubernetes authentication and authorization.
All metrics endpoints are now secured without depending on
gcr.io/kubebuilder/kube-rbac-proxy, which is now deprecated .