Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete COS bucket during teardown of cluster #10999

Merged
merged 1 commit into from
Dec 9, 2024
Merged

delete COS bucket during teardown of cluster #10999

merged 1 commit into from
Dec 9, 2024

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Dec 5, 2024

Description:

Currently we are leaving COS buckets in IBM cloud as leftovers which was created by noobaa. So we are fetching bucket from backingstore and deleting.

Signed-off-by: vavuthu vavuthu@redhat.com

@vavuthu vavuthu requested a review from a team as a code owner December 5, 2024 10:45
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Dec 5, 2024
@vavuthu vavuthu added team/ecosystem Ecosystem team related issues/PRs Needs Testing Run tests and provide logs link labels Dec 5, 2024
@vavuthu vavuthu force-pushed the delete_ibm_cos_bucket_during_teardown branch 2 times, most recently from 8477529 to 69161ff Compare December 5, 2024 11:46
@vavuthu
Copy link
Contributor Author

vavuthu commented Dec 5, 2024

verified: https://url.corp.redhat.com/26fdc79

logs

2024-12-05 21:47:16  11:17:16 - MainThread - /home/jenkins/workspace/qe-destroy-ocs-cluster/ocs-ci/ocs_ci/utility/ibmcloud.py - INFO  - Deleting bucket: nb.1733404663133.apps.vavuthuibmt3.*.com
2024-12-05 21:47:16  11:17:16 - MainThread - /home/jenkins/workspace/qe-destroy-ocs-cluster/ocs-ci/ocs_ci/utility/ibmcloud.py - INFO  - Retrieving bucket contents from nb.1733404663133.apps.vavuthuibmt3.*.com
2024-12-05 21:47:17  11:17:16 - MainThread - /home/jenkins/workspace/qe-destroy-ocs-cluster/ocs-ci/ocs_ci/utility/ibmcloud.py - INFO  - bucket objects: []
2024-12-05 21:47:17  11:17:17 - MainThread - /home/jenkins/workspace/qe-destroy-ocs-cluster/ocs-ci/ocs_ci/utility/ibmcloud.py - INFO  - Bucket: nb.1733404663133.apps.vavuthuibmt3.*.com deleted!

@vavuthu
delete COS bucket during teardown of cluster
295af66 
Description:

Currently we are leaving COS buckets in IBM cloud as leftovers
which was created by noobaa. So we are fetching bucket from backingstore and
deleting.

Signed-off-by: vavuthu <vavuthu@redhat.com>
@vavuthu vavuthu force-pushed the delete_ibm_cos_bucket_during_teardown branch from 69161ff to 295af66 Compare December 7, 2024 03:29
@vavuthu
Copy link
Contributor Author

vavuthu commented Dec 7, 2024

re-verified: https://url.corp.redhat.com/c2281f7

@vavuthu vavuthu added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Dec 7, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh petr-balogh merged commit 4295437 into red-hat-storage:master Dec 9, 2024
6 of 7 checks passed
@petr-balogh
Copy link
Member

@vavuthu please cherrypick down to 4.14

@vavuthu
Copy link
Contributor Author

vavuthu commented Dec 10, 2024

/cherry-pick release-4.17

@vavuthu
Copy link
Contributor Author

vavuthu commented Dec 10, 2024

/cherry-pick release-4.16

@vavuthu
Copy link
Contributor Author

vavuthu commented Dec 10, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: new pull request created: #11022

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 10, 2024
Merged
@vavuthu
Copy link
Contributor Author

vavuthu commented Dec 10, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: new pull request created: #11023

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 10, 2024
Open
@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: #10999 failed to apply on top of branch "release-4.15":

Applying: delete COS bucket during teardown of cluster
Using index info to reconstruct a base tree...
M	ocs_ci/deployment/ibmcloud.py
M	ocs_ci/ocs/resources/backingstore.py
M	ocs_ci/utility/ibmcloud.py
M	setup.py
Falling back to patching base and 3-way merge...
Auto-merging setup.py
Auto-merging ocs_ci/utility/ibmcloud.py
CONFLICT (content): Merge conflict in ocs_ci/utility/ibmcloud.py
Auto-merging ocs_ci/ocs/resources/backingstore.py
Auto-merging ocs_ci/deployment/ibmcloud.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 delete COS bucket during teardown of cluster

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: #10999 failed to apply on top of branch "release-4.14":

Applying: delete COS bucket during teardown of cluster
Using index info to reconstruct a base tree...
M	ocs_ci/deployment/ibmcloud.py
M	ocs_ci/ocs/resources/backingstore.py
M	ocs_ci/utility/ibmcloud.py
M	setup.py
Falling back to patching base and 3-way merge...
Auto-merging setup.py
CONFLICT (content): Merge conflict in setup.py
Auto-merging ocs_ci/utility/ibmcloud.py
CONFLICT (content): Merge conflict in ocs_ci/utility/ibmcloud.py
Auto-merging ocs_ci/ocs/resources/backingstore.py
CONFLICT (content): Merge conflict in ocs_ci/ocs/resources/backingstore.py
Auto-merging ocs_ci/deployment/ibmcloud.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 delete COS bucket during teardown of cluster

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-balogh petr-balogh petr-balogh approved these changes

@dahorak dahorak dahorak approved these changes

Assignees

@dahorak dahorak

@petr-balogh petr-balogh

Labels
lgtm size/L PR that changes 100-499 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vavuthu @petr-balogh @openshift-cherrypick-robot @dahorak