Adding functionality to set same token value across cluster #10801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahorak
previously approved these changes
Nov 5, 2024
petr-balogh
previously approved these changes
Nov 5, 2024
vavuthu
previously approved these changes
Nov 5, 2024
clacroix12
reviewed
Nov 5, 2024
shivamdurgbuns
dismissed stale reviews from shylesh, vavuthu, petr-balogh, and dahorak
via
9e0b435
petr-balogh
previously approved these changes
Nov 6, 2024
shivamdurgbuns
force-pushed
the
kms/OCSQE1636
branch
from
9e0b435 to
fd7bce2
Compare
clacroix12
previously approved these changes
Nov 7, 2024
shivamdurgbuns
force-pushed
the
kms/OCSQE1636
branch
from
fd7bce2 to
b6e3da5
Compare
shivamdurgbuns
dismissed stale reviews from clacroix12 and petr-balogh
via
be44ef2
shivamdurgbuns
force-pushed
the
kms/OCSQE1636
branch
from
b6e3da5 to
be44ef2
Compare
shivamdurgbuns
requested review from
vavuthu,
petr-balogh,
dahorak,
shylesh and
clacroix12
petr-balogh
previously approved these changes
Dec 2, 2024
shivamdurgbuns
force-pushed
the
kms/OCSQE1636
branch
from
be44ef2 to
6df1b1e
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shivamdurgbuns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shivamdurgbuns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clacroix12
requested changes
Dec 4, 2024
clacroix12
requested changes
Dec 5, 2024
ocs_ci/utility/kms.py
Outdated
Comment on lines
139
to
147
| @staticmethod | ||
| def set_vault_token(self): | ||
| """ | ||
| This is a static method that will set the token value. | ||
| """ | ||
| if self.vault_path_token is None: | ||
| self.vault_path_token = self.generate_vault_token() | ||
| return self.vault_path_token |
There was a problem hiding this comment.
Suggested change
| @staticmethod | |
| def set_vault_token(self): | |
| """ | |
| This is a static method that will set the token value. | |
| """ | |
| if self.vault_path_token is None: | |
| self.vault_path_token = self.generate_vault_token() | |
| return self.vault_path_token | |
| def get_vault_token(self): | |
| """ | |
| Get the Vault token value. Generate it first if it does not already exist. | |
| Returns: | |
| str: Vault token | |
| """ | |
| if self.vault_path_token is None: | |
| self.vault_path_token = self.generate_vault_token() | |
| return self.vault_path_token |
ocs_ci/utility/kms.py
Outdated
| @@ -578,7 +593,7 @@ def vault_create_policy(self, policy_name=None): | |||
| raise VaultOperationError( | |||
| f"Failed to create policy f{self.vault_policy_name}" | |||
| ) | |||
| self.vault_path_token = self.generate_vault_token() | |||
| self.vault_path_token = self.set_vault_token(self) | |||
There was a problem hiding this comment.
Suggested change
| self.vault_path_token = self.set_vault_token(self) | |
| self.vault_path_token = self.get_vault_token() |
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
… token value Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
shivamdurgbuns
force-pushed
the
kms/OCSQE1636
branch
from
6df1b1e to
ac0e253
Compare
clacroix12
reviewed
Dec 5, 2024
| @@ -578,7 +594,7 @@ def vault_create_policy(self, policy_name=None): | |||
| raise VaultOperationError( | |||
| f"Failed to create policy f{self.vault_policy_name}" | |||
| ) | |||
| self.vault_path_token = self.generate_vault_token() | |||
| self.vault_path_token = self.get_vault_token(self) | |||
There was a problem hiding this comment.
You don't need to explicitly pass this to the function anymore.
Suggested change
| self.vault_path_token = self.get_vault_token(self) | |
| self.vault_path_token = self.get_vault_token() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for Vault Configuration.
fixes: https://issues.redhat.com/browse/OCSQE-1636