Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing deleting procedure for the ceph FS #10148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shivamdurgbuns
Copy link
Member

Fixes issue #10084

@shivamdurgbuns shivamdurgbuns requested a review from a team as a code owner July 19, 2024 09:16
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Jul 19, 2024
Copy link

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivamdurgbuns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shivamdurgbuns shivamdurgbuns requested a review from a team as a code owner July 19, 2024 10:16
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-testcluster
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-cluster
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_cephfilesystem_creation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-cluster
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_cephfilesystem_creation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

cmd2 = "ceph fs rm test-ceph-fs --yes-i-really-mean-it"
ct_pod.exec_cmd_on_pod(cmd2)
logger.info("Deleting the Cephf Filesystem")
cephFS_obj.delete()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After cephFS_obj.delete(), I think we should add a check to wait for Pod removal before adding it again. Probably that's the leftover Pod being reported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamdurgbuns Please verify that the cephfilesystem is actually deleted.

cephFS_obj.ocp.wait_for_delete(
                cephFS_obj.name
            )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay will check it out

Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Sep 20, 2024
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines and removed size/M PR that changes 30-99 lines labels Sep 20, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-clus417
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_cephfilesystem_creation.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@nehaberry
Copy link
Contributor

I was talking to @shivamdurgbuns and I want to understand do we even support officially to create more than one cephfilesystem (data pool etc)

We can create multiple subvolumegroups within the default cephfilesystem that we get, but we shouldnt be creating more cephfilesystem (unlike blockpools which we can create as many as we want)

@jilju @ebenahar request you to add your views

In short, ceph osd lspools, should only list 2 pools - data and metadata for the default filesystem ocs-storagecluster-cephfilesystem

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale No recent activity label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale No recent activity size/S PR that changes 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants