Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18]: cephfs: log clone progress #426

Merged
merged 3 commits into from
Nov 26, 2024
Merged

[release-4.18]: cephfs: log clone progress #426

merged 3 commits into from
Nov 26, 2024

Conversation

Nikhil-Ladha
Copy link
Member

This PR contains backport commits from devel for 4.18 branch.

@Nikhil-Ladha Nikhil-Ladha requested a review from Madhu-1 November 26, 2024 14:04
@Nikhil-Ladha Nikhil-Ladha added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Nov 26, 2024
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Code looks good approved Its a good idea labels Nov 26, 2024
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

/hold

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

@Nikhil-Ladha can you please cherry-pick the commits? we only cherry-pick the commits when we want to backport to 4.18 branch

@Nikhil-Ladha
Copy link
Member Author

@Nikhil-Ladha can you please cherry-pick the commits? we only cherry-pick the commits when we want to backport to 4.18 branch

Sorry, didn't get you. I have cherry-picked the commits only, that were part of the other sync PR.

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

@Nikhil-Ladha can you please cherry-pick the commits? we only cherry-pick the commits when we want to backport to 4.18 branch

Sorry, didn't get you. I have cherry-picked the commits only, that were part of the other sync PR.

can you please use git cherry-pick -x to preserve the history of cherry-pick?

dependabot bot and others added 3 commits November 26, 2024 20:04
@dependabot @Nikhil-Ladha
rebase: bump github/codeql-action from 3.27.1 to 3.27.4
c2c2c62 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4f3212b...ea9e4e3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 86baab7)
@dependabot @Nikhil-Ladha
rebase: bump google.golang.org/protobuf from 1.35.1 to 1.35.2
5a179b0 
Bumps google.golang.org/protobuf from 1.35.1 to 1.35.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 23c1d7c)
@Nikhil-Ladha
cephfs: log clone progress
8827c7c 
log cephfs clone progress report during cephfs clone
operation

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
(cherry picked from commit 98cf078)
@openshift-ci openshift-ci bot removed the lgtm Code looks good label Nov 26, 2024
@Nikhil-Ladha
Copy link
Member Author

Nikhil-Ladha commented Nov 26, 2024 •
edited
Loading

Ack, updated the PR to cherry-pick using the -x flag, does it looks good now?

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Code looks good and removed do-not-merge/hold labels Nov 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 44b93cb into red-hat-storage:release-4.18 Nov 26, 2024
12 checks passed
@iPraveenParihar iPraveenParihar mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Awaiting requested review from Madhu-1

Assignees

@Madhu-1 Madhu-1

Labels
approved Its a good idea jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting lgtm Code looks good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nikhil-Ladha @Madhu-1