DFBUGS-906: Prevent dataloss due to the concurrent RPC calls (occurrence is very low) #425
Conversation
We should not be dependent on the CO to ensure that it will serialize the request instead of that we need to have own internal locks to ensure that we dont do concurrent operations for same request. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 38c0e64)
We should not be dependent on the CO to ensure that it will serialize the request instead of that we need to have own internal locks to ensure that we dont do concurrent operations for same request. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 38b0a4c)
using os.RemoveAll will remove everything in the director after the Umount we should be using os.Remove only to remove the empty directory Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit ffa8eaf)
using os.RemoveAll will remove everything in the director after the Umount we should be using os.Remove only to remove the empty directory Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 39cc628)
openshift-ci-robot
added
jira/severity-critical
|
@yati1998: This pull request references [Jira Issue DFBUGS-906](https://issues.redhat.com//browse/DFBUGS-906), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@Madhu-1: This pull request references [Jira Issue DFBUGS-906](https://issues.redhat.com//browse/DFBUGS-906), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@yati1998: This pull request references [Jira Issue DFBUGS-906](https://issues.redhat.com//browse/DFBUGS-906), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
1 similar comment
|
/jira refresh |
|
@yati1998: An error was encountered updating to the POST state for bug DFBUGS-906 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
Error marking step #34077648 finished: root cause: Tried to update an entity that does not exist.: request failed. Please analyze the request body for more details. Status code: 400:
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
@Madhu-1: This pull request references [Jira Issue DFBUGS-906](https://issues.redhat.com//browse/DFBUGS-906), which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: ypersky1980. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 1245510
into
red-hat-storage:release-4.18
|
@yati1998: [Jira Issue DFBUGS-906](https://issues.redhat.com//browse/DFBUGS-906): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-906](https://issues.redhat.com//browse/DFBUGS-906) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR includes series for commits for the following actions
Introduce in memory lock for NodePublish and UnPublish (we should not be dependent on the CO and make assumption that CO makes the calls serial for the same volID and the targetPath)
Use os.Remove instead of os.Removeall to remove the empty directory, os.Removeall ends up removing everything in the path