Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from devel for ceph-csi #422

Closed
wants to merge 9 commits into from

Conversation

df-build-team
Copy link

PR containing the latest commits from devel branch

dependabot bot and others added 9 commits November 20, 2024 09:50
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4f3212b...ea9e4e3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps google.golang.org/protobuf from 1.35.1 to 1.35.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Syncing latest changes from upstream devel for ceph-csi
We should not be dependent on the CO to ensure
that it will serialize the request instead of
that we need to have own internal locks to ensure
that we dont do concurrent operations for same
request.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
We should not be dependent on the CO to ensure
that it will serialize the request instead of
that we need to have own internal locks to ensure
that we dont do concurrent operations for same
request.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
using os.RemoveAll will remove everything
in the director after the Umount we should
be using os.Remove only to remove the empty
directory

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
using os.RemoveAll will remove everything
in the director after the Umount we should
be using os.Remove only to remove the empty
directory

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
log cephfs clone progress report during cephfs clone
operation

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Syncing latest changes from upstream devel for ceph-csi
@df-build-team df-build-team requested a review from a team November 22, 2024 16:07
@Nikhil-Ladha
Copy link
Member

@Madhu-1 can we please get this PR merged as well?

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Nov 26, 2024
@Nikhil-Ladha
Copy link
Member

I see that some of the commits are merged in the other PR :/

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Nov 26, 2024
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

I see that some of the commits are merged in the other PR :/

i thought we stopped syncing 4.18 branch and only do cherry-pick.

@Nikhil-Ladha
Copy link
Member

I see that some of the commits are merged in the other PR :/

i thought we stopped syncing 4.18 branch and only do cherry-pick.

Yeah, this PR was opened on Friday

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

@Nikhil-Ladha it looks like the bot required valid-bug label, do we need to add it manually?

@Nikhil-Ladha
Copy link
Member

@Nikhil-Ladha it looks like the bot required valid-bug label, do we need to add it manually?

I can add that manually, but what about the duplicate commits?

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 26, 2024

I see that some of the commits are merged in the other PR :/

i thought we stopped syncing 4.18 branch and only do cherry-pick.

Yeah, this PR was opened on Friday

As i was on PTO, this got slipped.

or close this and cherry-pick only required commit? like clone progress one?

@Nikhil-Ladha
Copy link
Member

No worries, seems like that's the best option i.e, to cherry-pick the commits.
We can merge that without a bug for now, and have the labels added manually.

@Nikhil-Ladha Nikhil-Ladha deleted the sync_ds--devel branch November 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants