Skip to content

Conversation

nixpanic
Copy link
Member

/cc iPraveenParihar
/assign Rakshith-R

Signed-off-by: Niels de Vos <ndevos@ibm.com>
Copy link

openshift-ci bot commented Nov 22, 2023

@nixpanic: GitHub didn't allow me to request PR reviews from the following users: iPraveenParihar.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc iPraveenParihar
/assign Rakshith-R

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Its a good idea label Nov 22, 2023
@openshift-ci openshift-ci bot added the lgtm Code looks good label Nov 22, 2023
Copy link

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthik-us, nixpanic, riya-singhal31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [karthik-us,nixpanic,riya-singhal31]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2f118e1 into red-hat-storage:devel Nov 22, 2023
@nixpanic
Copy link
Member Author

/cc iPraveenParihar

Copy link

openshift-ci bot commented Nov 22, 2023

@nixpanic: GitHub didn't allow me to request PR reviews from the following users: iPraveenParihar.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc iPraveenParihar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member Author

/cc iPraveenParihar

Copy link
Member

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@iPraveenParihar
Copy link
Member

I don't see approve button under review.

@iPraveenParihar
Copy link
Member

iPraveenParihar commented Nov 22, 2023

Oops, my bad there was some glitch.
PR was still showing as Open and now its merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants