Skip to content

nagoya-university-conversation-corpus: fix typo #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tikkss
Copy link
Contributor

@tikkss tikkss commented Sep 5, 2024

Before change:

$ git grep --ignore-case curpus
lib/datasets/nagoya-university-conversation-corpus.rb:      @metadata.id = 'nagoya-university-conversation-curpus'
lib/datasets/nagoya-university-conversation-corpus.rb: @metadata.name = 'Nagoya University Conversation Curpus'

After change:

$ git grep --ignore-case curpus

Before change:

```console
$ git grep --ignore-case curpus
lib/datasets/nagoya-university-conversation-corpus.rb:      @metadata.id = 'nagoya-university-conversation-curpus'
lib/datasets/nagoya-university-conversation-corpus.rb: @metadata.name = 'Nagoya University Conversation Curpus'
```

After change:

```console
$ git grep --ignore-case curpus
```
@kou kou merged commit 6ed8a8f into red-data-tools:master Sep 5, 2024
12 checks passed
@kou
Copy link
Member

kou commented Sep 5, 2024

Good catch!

@tikkss tikkss deleted the nagoya-university-conversation-corpus-fix-typo branch September 5, 2024 20:44
@tikkss
Copy link
Contributor Author

tikkss commented Sep 5, 2024

Yeah! Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants