This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
forked from vitessio/vitess
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Generate protobuf files during compilation and fix the generation rules.
The change achieves the following: 1. Adds generation of Go and Python protobuf files during build by adding dependency of 'build' rule on 'proto' rule. This will avoid surprises of 'make build' giving error when proto file is changed. 2. Modifies the generation of protobuf files to be more in line of how Makefiles should be written. This has an additional benefit that protobuf files won't be regenerated if proto files did not change. 3. Modifies the generation rules to work both locally on a workstation and inside the docker image. Docker image doesn't have /vt/dist/grpc installed, so the existing rule didn't work. Note that as a result of this a new directory go/vt/.proto.tmp will exist after building. I believe that should be fine and won't interfere with anything.
- Loading branch information
Showing
2 changed files
with
45 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,3 +62,6 @@ _test/ | |
|
||
#pom generated file | ||
/java/jdbc/dependency-reduced-pom.xml | ||
|
||
# generated protobuf files | ||
/go/vt/.proto.tmp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters