chore: extract loading braintree libraries to util/braintree #891
+76
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates loading Braintree dependencies into a shared module instead
of copying it around each module that has a Braintree integration.
```js
import BraintreeLoader from 'path/to/./util/braintree-loader';
BraintreeLoader.loadModules('applePay', 'dataCollector')
.catch(...)
.then(...)
```
`ApplePaySession` is stubbed out for the unit tests, so it should not matter which browser is running the tests.
cbarton
force-pushed
the
consolidate-braintree
branch
from
9eeb1f9
to
b10f978
Compare
chrissrogers
approved these changes
Aug 14, 2024
|
Excellent |
recurly-integrations
pushed a commit
that referenced
this pull request
Aug 26, 2024
[Full Changelog](v4.29.2...v4.29.3) **Merged Pull Requests** - Ensures setup fees are not applied to subscriptions with quantity = 0 [#893](#893) ([chrissrogers](https://github.com/chrissrogers)) - chore: convert Google Pay element to a class from function [#892](#892) ([cbarton](https://github.com/cbarton)) - chore: extract loading braintree libraries to util/braintree [#891](#891) ([cbarton](https://github.com/cbarton)) ##### Minified MD5 Checksum ``` 3aedc5c6a5c87365133c8b23feb32f0c ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` lhLNZJ447F9CH0rGPYMNS3NV3Nwnn4Y3oaUsbTa3cAQ/J7XDX76JAa2Htis2bEro ```
recurly-integrations
pushed a commit
that referenced
this pull request
Aug 26, 2024
[Full Changelog](v4.29.2...v4.29.4) **Merged Pull Requests** - Ensures addons are not included in subscriptions with quantity = 0 [#895](#895) ([chrissrogers](https://github.com/chrissrogers)) - Ensures setup fees are not applied to subscriptions with quantity = 0 [#893](#893) ([chrissrogers](https://github.com/chrissrogers)) - chore: convert Google Pay element to a class from function [#892](#892) ([cbarton](https://github.com/cbarton)) - chore: extract loading braintree libraries to util/braintree [#891](#891) ([cbarton](https://github.com/cbarton)) ##### Minified MD5 Checksum ``` 42050ba64172af4e291a37545fa905de ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` OHnJ0LXZyg2EpXal64oDpbfmLPrToCaWpN792/a3zsj6my6ILT6bd9k7NVaZFxge ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates loading Braintree dependencies into a shared module instead of copying it around each module that has a Braintree integration.