-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple pay): populate billingContact with form address fields #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbarton
force-pushed
the
apple-pay-billing-contact
branch
from
March 27, 2023 23:15
210efdf
to
8e00517
Compare
cbarton
force-pushed
the
apple-pay-billing-contact
branch
from
March 28, 2023 19:09
8e00517
to
b85f5d7
Compare
cbarton
force-pushed
the
apple-pay-billing-contact
branch
from
March 29, 2023 18:21
b85f5d7
to
edbd256
Compare
…ields Apple Pay on the Web supports supplying a `billingContact` and `shippingContact` when creating the session. If provided, it would populate over the customer's default billing contact on the payment sheet. If the `form` option is supplied, use the address fields that are populated to populate the `billingContact` and the shipping fields that are populated to populate the `shippingContact`. This also cleans up the interaction between the `form` and the token. Currently, if any of the fields on the `form` are present, we prefer that address instead of what is presented and modified on the payment card. This changes that functionality to always prefer the `billingContact` from the payment card when tokenizing the card as that is what the customer sees when authorizing the payment.
cbarton
force-pushed
the
apple-pay-billing-contact
branch
from
March 29, 2023 23:17
edbd256
to
53f8914
Compare
chrissrogers
approved these changes
Mar 30, 2023
recurly-integrations
pushed a commit
that referenced
this pull request
Apr 19, 2023
[Full Changelog](v4.22.9...v4.23.0) **Merged Pull Requests** - chore(paypal): add types for display options [#812](#812) ([cbarton](https://github.com/cbarton)) - fix(apple pay): Do not teardown Braintree on cancel [#811](#811) ([cbarton](https://github.com/cbarton)) - fix(types): add type definition for Recurly#ready [#810](#810) ([cbarton](https://github.com/cbarton)) - feat(google pay): add support for the paymentDataRequest [#809](#809) ([cbarton](https://github.com/cbarton)) - feat(Apple Pay): allow for customization of event updates [#808](#808) ([cbarton](https://github.com/cbarton)) - Update config type with requiredShippingContactFields [#806](#806) ([BARK-RMILLER](https://github.com/BARK-RMILLER)) - feat(apple pay): add support for `recurringPaymentRequest`, move to `options.paymentRequest` [#804](#804) ([cbarton](https://github.com/cbarton)) - fix(apple pay): emit events when restore pricing addresses [#803](#803) ([cbarton](https://github.com/cbarton)) - chore(apple pay): capture async test errors to fail faster [#802](#802) ([cbarton](https://github.com/cbarton)) - feat(apple pay): populate contacts with pricing addresses [#801](#801) ([cbarton](https://github.com/cbarton)) - feat(apple pay): allow for supportedNetworks selection [#800](#800) ([cbarton](https://github.com/cbarton)) - feat(apple pay): update tax when billing/shipping contact changes [#798](#798) ([cbarton](https://github.com/cbarton)) - feat(apple pay): populate billingContact with form address fields [#797](#797) ([cbarton](https://github.com/cbarton)) - feat(Apple Pay): validate and support more ApplePayPaymentRequest features [#794](#794) ([cbarton](https://github.com/cbarton)) - [feat][google-pay] send raw payment data to server [#789](#789) ([cbarton](https://github.com/cbarton)) **Closed Issues** - property 'ready' does not exist on type 'Recurly'.ts [#795](#795) - Missing types definitions for `coupon` method [#698](#698) - If formRef unmounts during call, recurly.token fails silently. [#697](#697) - The user can enter 4 digits as the month value in the expiration date field. [#678](#678) ##### Minified MD5 Checksum ``` 75584733b78f6ca6c6a65267b07fb9ad ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` pX41INy9qepZfHHYL13noWEbReg+bDOqU2jzjgkC3kkDh36KlPFeiJBxUgca8DtP ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Pay on the Web supports supplying a
billingContact
andshippingContact
when creating the session. If provided, it wouldpopulate over the customer's default billing contact on the payment
sheet.
If the
form
option is supplied, use the address fields that arepopulated to populate the
billingContact
and the shipping fieldsthat are populated to populate the
shippingContact
.This also cleans up the interaction between the
form
and the token.Currently, if any of the fields on the
form
are present, we preferthat address instead of what is presented and modified on the payment
card. This changes that functionality to always prefer the
billingContact
from the payment card when tokenizing the card asthat is what the customer sees when authorizing the payment.