Fixes coupon resolving when switching subscription plans #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When switching plans on a SubscriptionCheckout instance, the constituent discounts must be checked for compatibility and removed accordingly - Fixes #488
chrissrogers
force-pushed
the
fix-coupon-plan-resolution
branch
from
c67d9a2 to
e9597fa
Compare
chrissrogers
commented
Oct 31, 2018
| @@ -1,7 +1,7 @@ | |||
| language: node_js | |||
| sudo: false | |||
| node_js: | |||
| - 'node' | |||
| - 10 | |||
There was a problem hiding this comment.
I had to pin this at node v10 to alleviate issues in CI -- cause as yet is undetermined. Only PhantomJS runs were affected by the bump to node v11, perhaps due to the wide impact of its upgrade of v8 internals.
Merged
csmb
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscriptionCheckoutinstance,the constituent discounts must be checked for compatibility and
removed accordingly