Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurly.Event #459

Merged
merged 26 commits into from
Aug 9, 2018
Merged

Recurly.Event #459

merged 26 commits into from
Aug 9, 2018

Conversation

chrissrogers
Copy link
Member

@chrissrogers chrissrogers commented Apr 27, 2018 •
edited
Loading

  • Base branch for Recurly.event feature

@chrissrogers chrissrogers force-pushed the events branch 2 times, most recently from 20e7c76 to fb7c2c7 Compare April 27, 2018 16:44
@chrissrogers chrissrogers changed the title [WIP] Recurly.Event Recurly.Event May 7, 2018
snodgrass23
snodgrass23 reviewed May 30, 2018
View reviewed changes
lib/recurly/event.js Outdated
* @param {Object} options
* @param {String} options.name event name
*/
payload ({ name }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on using other properties in the future? If not, probably easier to just accept a single string argument instead of passing in the whole object and pulling a single prop.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly, the payload here will accept more properties as they are introduced. Those will come in an upcoming PR to this branch.

gla7
gla7 approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@gla7 gla7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrissrogers
Adds storage, deviceId, and sessionId tests
f56bef6 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds Recurly.event
dedd063 
- Adds `EventDispatcher`, instantiated on each `Recurly` instance at `recurly.event`

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Allows deviceId and sessionId to be set directly
405dd50 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Passes deviceId and sessionId to hosted fields
139ff1d 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds Event initiatedAt property
5d0c7a1 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds events on instance creation and readiness
80b3f06 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds instanceId to event payload
05b2095 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds instance configuration and ready events
a8b41e0 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds Request.queued
c9e1534 
- Queues requests to fire until the instance is ready to make requests

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Updates errors module to log error events
1771b40 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds ErrorDirectory
8da3af8 
- Improved organization of error generation

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Updates error module imports
25f754c 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Moves version module
496b17f 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds RecurlyError specs
d26a4a1 
- Fixes ErrorDirectory init

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Changes error classifications
de2d165 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Batches event requests
4b977fe 
- Adds IntervalWorker
- Updates EventDispatcher to use a worker to dispatch events in ten second intervals
- Updates Request to accept empty responses

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Fixes worker specs
3507ef3 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Dispatches events when a hosted field interaction occurs
c70a10d 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Pricing events
e841ba6 
- Dispatches events when pricing changes occur

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Sends events metadata
53d414d 
- Metadata is used to send useful information alongside an event

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Renames EventDispatcher to Reporter
816b7fd 
- Adds Recurly.report to simplify calls
- Updates pricing meta payloads

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Adds pricing type specificity to reports
88615b4 
- differentiates between ‘checkout’ and ‘subscription’ reporting

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Fixes mutability of objects emitted from pricing instances
ae4e7e6 
- Clones owned objects before they are emitted
- Checkout and Subscription pricing instances would return objects in their proomise chains which could mutate the corresponding item on the pricing instance

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Fixes coupon unset events
709e576 
- Setting a coupon on a pricing instance would unnecessarily try to unset prior coupoons, resulting in noisy events
- unset.coupon will now only fire if an exisiting coupoon oon a pricing instance is removed

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>

# Conflicts:
#	lib/recurly/pricing/checkout/index.js
@chrissrogers
Fixes JSONP reporting errors in specs
f4791e8 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@chrissrogers
Fixes typo
fc2102a 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
@gla7 gla7 merged commit c6333a5 into master Aug 9, 2018
@gla7 gla7 deleted the events branch August 9, 2018 21:26
carlosantoniodasilva referenced this pull request Sep 27, 2018
@chrissrogers
Version 4.9.1
f70974e 
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snodgrass23 snodgrass23 snodgrass23 left review comments

@gla7 gla7 gla7 approved these changes

Assignees
No one assigned
Labels
changelog new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrissrogers @snodgrass23 @gla7