Fixes bug around initial pricing not respecting coupons #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If a coupon code was pre-populated into a priced field, it was not initially added to the pricing instance structure - Removes `pricing.binding` alias for `pricing.attach`. It had been deprecated since Recurly.js v3 alpha phases. Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
chrissrogers
force-pushed
the
pricing-attach-init
branch
from
3126462 to
49ec348
Compare
- Reorganizes pricing tests - Adds attachment test for pre-populated coupons - s/detatch/detach Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
chrissrogers
force-pushed
the
pricing-attach-init
branch
from
49ec348 to
5feb0d8
Compare
| * @deprecated | ||
| */ | ||
|
|
||
| exports.binding = attach; |
There was a problem hiding this comment.
It was about time this went away
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pricing.bindingalias forpricing.attach. It had been deprecated since Recurly.js v3 alpha phasesRepro steps