Outdated types on DefinitelyTyped #694
Comments
|
Even with #696 having been merged, this is still failing. https://github.com/recurly/recurly-js/actions/runs/1365679188 Using the library is not a good experience at the moment because of things like this. |
|
@javimbk sorry for not replying sooner. Sorry for this causing issues on your end! We'll have a look at this to get that pipeline back in good standing. |
|
@javimbk we've repaired that pipeline, so types will now update in concert with library updates. Thanks so much for your patience on this. |
recurly-integrations
pushed a commit
that referenced
this issue
Nov 9, 2021
[Full Changelog](v4.18.0...v4.18.1) **Merged Pull Requests** - Round tax amount instead of ceil [#690](#690) ([judith](https://github.com/judith)) **Closed Issues** - Outdated types on DefinitelyTyped [#694](#694) ##### Minified MD5 Checksum ``` f5c1a4bfbf8a1fa4314493f1eb413dbb ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` lLZfMuhejEXFJ8bD8xn46Ooyw9Z8ZaduUDIYkHko96+mf6mMJXUm6LQ9NOCVTij7 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Last update on DefinitelyTyped was on April 2021, and since then there have been some changes in the types inside this library.
According to the README on DefinitelyTyped:
In order to make sure the types for Recurly.js are kept up to date when new versions are released, the base types are contained in the Recurly.js repository.
To make a contribution and update the types for Recurly.js, open a pull request to update the types on Recurly.js. After it gets merged, an automated process will open a pull request with your new changes to DefinitelyTyped when the next version of Recurly.js is released.
It seems that something has gone wrong on the publishing on DefinitelyTyped, it's easy to see when checking the Github Actions of this repo.
Could we get a fix on this and get the latest updates? In my case I'm missing the changes to
RecurlyErrorthat were introduced on #680 , but I just think that having the updated types is worth the effort.Thanks in advance.
The text was updated successfully, but these errors were encountered: