Fixes coupon validity method safety

Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
recurly · Nov 7, 2017 · fbb652c · fbb652c
1 parent 31a01ed
commit fbb652c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/recurly/pricing/subscription/index.js b/lib/recurly/pricing/subscription/index.js
@@ -245,11 +245,11 @@ export default class SubscriptionPricing extends Pricing {
 
       const receiveCoupon = (err, coupon) => {
         if (err && err.code === 'not-found') unsetCoupon();
-        if (!this.couponIsValidForSubscription(coupon)) {
-          return this.error('invalid-coupon-for-subscription', reject, 'coupon');
-        }
         if (err) {
           return this.error(err, reject, 'coupon');
+        }
+        if (!this.couponIsValidForSubscription(coupon)) {
+          return this.error('invalid-coupon-for-subscription', reject, 'coupon');
         } else {
           debug('set.coupon');
           this.items.coupon = coupon;
@@ -354,6 +354,7 @@ export default class SubscriptionPricing extends Pricing {
    * @return {Boolean}
    */
   couponIsValidForSubscription (coupon) {
+    if (!coupon) return false;
     if (!coupon.applies_to_plans) return false;
     if (coupon.applies_to_all_plans) return true;
     if (~coupon.plans.indexOf(this.items.plan.code)) return true;