Merge pull request #504 from recurly/fix-tabbing-mobile

Fixes detection of tabbing order on mobile browsers
recurly · Jan 17, 2019 · a87b9f1 · a87b9f1
2 parents 3466b44 + 07d5606
commit a87b9f1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/lib/recurly/hosted-fields.js b/lib/recurly/hosted-fields.js
@@ -160,8 +160,14 @@ export class HostedFields extends Emitter {
     if (destination) destination.focus();
   }
 
+  /**
+   * Provides an Array of tabbable Elements in the document body,
+   * excluding those which correspond to hosted field iframes
+   * @return {Array} Elements
+   */
   tabbableItems () {
-    return tabbable(window.document.body);
+    const fieldFrames = this.fields.map(f => f.iframe);
+    return tabbable(window.document.body).filter(el => !~fieldFrames.indexOf(el));
   }
 
   update (body) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
     "lodash.pick": "^4.4.0",
     "promise": "^8.0.2",
     "qs": "^6.5.2",
-    "tabbable": "^3.1.1",
+    "tabbable": "^3.1.2",
     "to-slug-case": "^1.0.0",
     "uuid": "^3.3.2"
   },