Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for Java Early Access #17

Merged
merged 4 commits into from
Jul 12, 2019
Merged

Small fixes for Java Early Access #17

merged 4 commits into from
Jul 12, 2019

Conversation

aaron-junot
Copy link
Contributor

@aaron-junot aaron-junot commented Jul 9, 2019 •
edited
Loading

This change makes several small fixes needed before we can go Early Access with this library:

  • Target Java 11
  • Adds scripts/format to enforce style
  • Sets RECURLY_INSECURE in the test script without exporting an actual environment variable
  • Regenerated client to add @expose tags and formatting

@aaron-junot aaron-junot added the WIP label Jul 9, 2019
@aaron-junot aaron-junot requested a review from bhelx July 9, 2019 22:12
@aaron-junot aaron-junot removed the WIP label Jul 11, 2019
bhelx
bhelx approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit df83921 into 3_0_0_beta Jul 12, 2019
@bhelx bhelx deleted the improve-java branch July 12, 2019 16:28
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
V3 v2019-10-10 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaron-junot @bhelx @joannasese