Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getUnsafeHttpClient in favor of a normal OkHttpClient #15

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Remove getUnsafeHttpClient in favor of a normal OkHttpClient #15

merged 1 commit into from
Jul 8, 2019

Conversation

aaron-junot
Copy link
Contributor

This removes the method getUnsafeOkHttpClientBuilder(). All smoke tests pass for all environments on my machine, provided V3_RUNTIME=host.

@aaron-junot aaron-junot requested a review from bhelx July 8, 2019 19:22
bhelx
bhelx approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit 7e8e682 into 3_0_0_beta Jul 8, 2019
@bhelx bhelx deleted the remove-unsafe-httpclient branch July 8, 2019 20:15
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
V3 v2019-10-10 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaron-junot @bhelx @joannasese