Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes PropTypes.fraud.kount.dataCollector in <Provider /> #92

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Fixes PropTypes.fraud.kount.dataCollector in <Provider /> #92

merged 1 commit into from
Aug 21, 2020

Conversation

dbrudner
Copy link
Contributor

@dbrudner dbrudner commented Aug 4, 2020 •
edited
Loading

Just a quick correction, PropTypes.boolean doesn't exist and should be PropTypes.bool

https://reactjs.org/docs/typechecking-with-proptypes.html#proptypes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 597

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.182%
Totals Coverage Status
Change from base Build 595: 0.0%
Covered Lines: 215
Relevant Lines: 216
💛 - Coveralls

douglasmiller
douglasmiller approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@douglasmiller douglasmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@douglasmiller douglasmiller merged commit cb2cfe8 into main Aug 21, 2020
@douglasmiller douglasmiller deleted the provider-proptypes branch August 21, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglasmiller douglasmiller douglasmiller approved these changes

@chrissrogers chrissrogers Awaiting requested review from chrissrogers

@joannasese joannasese Awaiting requested review from joannasese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbrudner @coveralls @douglasmiller