adjust demo package to fix CodeSandbox setup #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissrogers
approved these changes
Oct 4, 2023
|
Thank you for this contrib! I'll merge it once tests pass. Using the github reference was meant to keep the demo as up to date with the main branch as possible, but I think that this approach is much safer and matches production deployments. And clearly the existing github reference doesn't work for codesandbox any more, so this is much better. |
douglasmiller
approved these changes
Oct 4, 2023
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 12, 2023
[Full Changelog](v2.0.0...v2.0.1) **Merged Pull Requests** - adjust demo package to fix CodeSandbox setup [#220](#220) ([chrisdeely](https://github.com/chrisdeely)) - Adds hostname configuration [#217](#217) ([chrissrogers](https://github.com/chrissrogers))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #219
These changes repaired the CodeSandbox referenced within the documentation. I'll admit that I don't know the history/rationale behind directly referencing the GitHub repo as the dependency location, so this may not be an appropriate fix.
Example sandbox