Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Risk data collector form passing #197

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Risk data collector form passing #197

merged 2 commits into from
Nov 29, 2022

Conversation

abachman
Copy link
Contributor

Problem

The <RiskDataCollector /> component should call recurly.configure with an instance of an HTML Form Element, but right now it's passing a React.createRef() object instead.

Solution

  • Pass container.current as the form: value instead of container.
  • Add a test covering this behavior

@coveralls
Copy link

Pull Request Test Coverage Report for Build 907

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.947%
Totals Coverage Status
Change from base Build 895: 0.0%
Covered Lines: 222
Relevant Lines: 222
💛 - Coveralls

CJ-Howard
CJ-Howard approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@CJ-Howard CJ-Howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes and ran tests locally, all passed.

@CJ-Howard CJ-Howard merged commit be7ee31 into main Nov 29, 2022
@CJ-Howard CJ-Howard deleted the risk-data-collector-form-passing branch November 29, 2022 22:22
recurly-integrations pushed a commit that referenced this pull request Nov 30, 2022
1.2.7
38a68ee 
[Full Changelog](v1.2.6...v1.2.7)

**Merged Pull Requests**

- Risk data collector form passing [#197](#197) ([abachman](https://github.com/abachman))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJ-Howard CJ-Howard CJ-Howard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abachman @coveralls @CJ-Howard