NewInInitializerRector creates bugs

[VincentLanglet]

Bug Report

The NewInInitializer rule is changing the property from non nullable to nullable
https://getrector.com/rule-detail/new-in-initializer-rector
This is a real issue when the property is used later.

With the exemple of the rule new SomeClass(null) will create bug when $this->logger is used ; while it worked before.

Subject	Details
Rector version	latest

Minimal PHP Code Causing Issue

https://getrector.com/demo/54bb158c-7a82-4d59-8fd2-c66eff068eef
See https://3v4l.org/VcW9g#v8.3.30

Expected Behaviour

[samsonasik]

I think for safer use is by keep this line:

$this->foo = $foo ?? new Bar();

The params now become property promotion, and fallback early, but if passed null on the caller, the fallback will handle.

see https://3v4l.org/8f3SR#v8.3.30

[VincentLanglet]

I think for safer use is by keep this line:

$this->foo = $foo ?? new Bar();

Then the new Bar() inside the __construct becomes kinda useless since private ?Bar $foo = null would work the same way.

Also, another issue of the NewInInitializerRector rule is for static analysis, since the property become from non nullable into nullable, and then you ends up with error reported by PHPStan
https://phpstan.org/r/df014ca9-7d98-490e-9ec8-599e9032fbb8

[samsonasik]

I see, I think the rule itself is unusable in real life project then, and needs to be deprecated /cc @TomasVotruba

[TomasVotruba]

@samsonasik I'm affraid you're right. This is at least 3rd such a report. It depends on the context, and can break.

Let's deprecated it then.