Rector does not consistently propose to use promoted properties

[theofidry]

Bug Report

Subject	Details
Rector version	Rector 2.0.10
PHP version	8.4.2

Issue

Rector is proposing the following change:

1) src/Bridge/Eloquent/Purger/ModelPurger.php:29

    ---------- begin diff ----------
@@ @@
     use IsAServiceTrait;

     private Migrator $migrator;
-    private string $migrationPath;
     private MigrationRepositoryInterface $repository;

-    public function __construct(MigrationRepositoryInterface $repository, string $migrationPath, Migrator $migrator)
+    public function __construct(MigrationRepositoryInterface $repository, private string $migrationPath, Migrator $migrator)
     {
         $this->migrator = $migrator;
-        $this->migrationPath = $migrationPath;
         $this->repository = $repository;
     }
    ----------- end diff -----------

Applied rules:
 * ClassPropertyAssignToConstructorPromotionRector

The rule applied ClassPropertyAssignToConstructorPromotionRector looks correct but for some reason it did not apply it to the parameters $repository and $migrator.

Reproducer

I could get this error in this PR theofidry/AliceDataFixtures#294 but to narrow down the issue I extracted theofidry/AliceDataFixtures#296.

Expected Behaviour

Rector should propose the following diff instead:

1) src/Bridge/Eloquent/Purger/ModelPurger.php:29

    ---------- begin diff ----------
@@ @@
     use IsAServiceTrait;

-     private Migrator $migrator;
-    private string $migrationPath;
-     private MigrationRepositoryInterface $repository;

-    public function __construct(MigrationRepositoryInterface $repository, string $migrationPath, Migrator $migrator)
+    public function __construct(private MigrationRepositoryInterface $repository, private string $migrationPath, private Migrator $migrator)
     {
-         $this->migrator = $migrator;
-        $this->migrationPath = $migrationPath;
-         $this->repository = $repository;
     }
    ----------- end diff -----------

Applied rules:
 * ClassPropertyAssignToConstructorPromotionRector

[samsonasik]

similar with #9054, ensure that autoload correctly setup, and class correctly autoloaded so phpstan know it exists.

[theofidry]

@samsonasik maybe I'm being dumb but why does it matter at all? I don't think it's a case where the fact that the class used actually is defined elsewhere matters. Even if the class used was actually not defined, I don't see why the above should not work?

[samsonasik]

if it not autoload, it may become UnexistenceObjectType which may target type may not correct. Running rector is better from root project, and ensure vendor/autoload or other bootstrap correctly setup, otherwise, it may cause autoload juggling.