Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullsafeOperatorRector crash #6632

Closed
olivernybroe opened this issue Aug 13, 2021 · 2 comments · Fixed by rectorphp/rector-src#682
Closed

NullsafeOperatorRector crash #6632

olivernybroe opened this issue Aug 13, 2021 · 2 comments · Fixed by rectorphp/rector-src#682
Labels
bug

Comments

@olivernybroe
Copy link
Contributor

Bug Report

Subject Details
Rector version v0.11.47

When having the following code the NullsafeOperatorRector crashes. I am not exactly sure why, but left a demo to show it.

Minimal PHP Code Causing Issue

https://getrector.org/demo/1ebfc1d2-6817-6c7a-9757-fbafc5b16667

Expected Behaviour

That it doesn't crash 👍
@TomasVotruba
Copy link
Member

Thank you for your report and demo link!

Could you send a failing test case in a pull-request, so we have it covered in Rector?
Here is step by step tutorial how to add it: https://github.com/rectorphp/rector/blob/master/docs/how_to_add_test_for_rector_rule.md

@olivernybroe
Copy link
Contributor Author

Yeah, just got a bit lazy after creating two other bug reports for this one 😅

I'll do it later 👍

@Bl00D4NGEL Bl00D4NGEL mentioned this issue Aug 14, 2021
Merged
TomasVotruba added a commit that referenced this issue Dec 27, 2024
@TomasVotruba
Updated Rector to commit 7bbe9ba2af41fbb64a2817cd44d19665aa79f186
24e1aac 
rectorphp/rector-src@7bbe9ba [DX] Warn about ->withPhpSets() called multiple times, to avoid invalid set mix (#6632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@TomasVotruba @olivernybroe