[TypeDeclaratio] Skip abstract method in AddVoidReturnTypeWhereNoRetu…

…rnRector (#6173)
rectorphp · Apr 20, 2021 · d723aca · d723aca
1 parent cd3725a
commit d723aca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/...tor/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/skip_abstract_method.php.inc b/...tor/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/skip_abstract_method.php.inc
@@ -0,0 +1,6 @@
+<?php
+
+abstract class SkipAbstractMethod
+{
+    public abstract function getValues();
+}
diff --git a/...ration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/config/configured_rule.php b/...ration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/config/configured_rule.php
@@ -7,6 +7,5 @@
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $services = $containerConfigurator->services();
-
     $services->set(AddVoidReturnTypeWhereNoReturnRector::class);
 };
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php
@@ -82,7 +82,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($node instanceof ClassMethod && $node->isMagic()) {
+        if ($node instanceof ClassMethod && ($node->isMagic() || $node->isAbstract())) {
             return null;
         }