[symfony 7] update sets #890
Conversation
TomasVotruba
force-pushed
the
tv-symfony-7-series
branch
from
33d9659 to
e783699
Compare
| public function getRuleDefinition(): RuleDefinition | ||
| { | ||
| return new RuleDefinition( | ||
| 'Remove unused UserInterface::eraseCredentials() method, make it part of serialize if needed', |
There was a problem hiding this comment.
The method is still necessary in sf 7.x, because it is still part of the interface. Without the method you get an exception:
Class App\Entity\User contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Symfony\Component\Security\Core\User\UserInterface::eraseCredentials)
There was a problem hiding this comment.
I see. Where would you place it?
There was a problem hiding this comment.
I think the method should be removed by a sf8 rule. the sf7 rule should keep the empty method with a #[Deprecated] attribute, because this prevents the deprecation notice in symfony:
This PR leverages the new #[\Deprecated] attribute to decide if some eraseCredentials() method is to be called or not.
My target DX here is to save us all (the community) from having to add erase_credentials: false configuration in all our apps.
So, instead of having to opt-out from the deprecation using this config option, the opt-out is done by adding the attribute on the method:
There was a problem hiding this comment.
Sounds good. Could you move the rule to SF8?
Resources