Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preload.php order to included firstly used classes first, to avoid missing parent bugs #929

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Fix preload.php order to included firstly used classes first, to avoid missing parent bugs #929

merged 6 commits into from
Sep 28, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Sep 28, 2021 •
edited
Loading

Bug discovered in rectorphp/rector#6709

@TomasVotruba TomasVotruba changed the title tv preload order fix Fix preload.php order to included firstly used classes first, to avoid missing parent bugs Sep 28, 2021
@TomasVotruba TomasVotruba enabled auto-merge (squash) September 28, 2021 16:00
@TomasVotruba TomasVotruba merged commit af0fc79 into main Sep 28, 2021
@TomasVotruba TomasVotruba deleted the tv-preload-order-fix branch September 28, 2021 16:02
@TomasVotruba
Copy link
Member Author

Caused by fe6e7d5 (#904) cc @samsonasik

The build-preload.php script was manually tuned after the generation, so it was only logical this will break on automated break.

I've fixed it here and add test to CI so we know about it sooner next time 👍

@samsonasik
Copy link
Member

@TomasVotruba thank you for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @samsonasik