Repository navigation
[trav] Move rule selection to RectorRegistry - #8619
Open
TomasVotruba wants to merge 7 commits into
Open
TomasVotruba wants to merge 7 commits into
TomasVotruba wants to merge 7 commits into
Conversation
TomasVotruba
changed the title
TomasVotruba
marked this pull request as ready for review
October 11, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves per-node rule selection and filtering out of
RectorNodeTraverserintoRectorRegistry.Changes
RectorNodeTraversernow delegates toRectorRegistry::forNode()instead of its owngetVisitorsForNode()/refreshPhpRectors(); PHP-version, composer-constraint and configuration filtering live inRectorRegistry::filterRectors().RectorRegistry::refreshRectors()now also clears theforNodecache, so a refreshed rule set is not shadowed by stale per-node cache entries (surfaced by the shared container across test classes).refreshPhpRectors()call fromAbstractRectorTestCase; the registry sync right below it already keeps rules in step.StopTraverseOnTypeChangeTestand a rewrittenRectorRegistryTestdriveRectorRegistry; the orphanedRectorNodeTraverserTest(only tested the removedgetVisitorsForNode) is folded intoRectorRegistryTest.