feat(printer): add per-node NEWLINE_ON_FLUENT_CALL attribute to BetterStandardPrinter#7910
Open
MrPunyapal wants to merge 3 commits intorectorphp:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a per-node attribute
AttributeKey::NEWLINE_ON_FLUENT_CALLso individualMethodCallnodes can opt into newline-on-fluent formatting without enabling the globalnewLineOnFluentCall()option.Motivation
The printer currently only checks the global
Option::NEW_LINE_ON_FLUENT_CALLflag. When a rule enables that option globally, every fluent chain across the processed codebase is reformatted. This causes undesirable, wide-ranging formatting changes. A per-node attribute lets rules request one-method-per-line formatting for specific nodes (for example,expect()chains) without affecting unrelated code.Example
When creating a
MethodCallnode in a Rector rule, tag it to enable newline formatting: