Skip null type in ReturnTypeFromStrictScalarReturnExprRector as often not desired #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Jan 13, 2024
| @@ -117,6 +118,11 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node | |||
| return null; | |||
| } | |||
|
|
|||
| // skip null as often placeholder value and not an only type | |||
| if ($scalarReturnType instanceof NullType) { | |||
There was a problem hiding this comment.
this should be fine on Function_, Closure, and when class is final, so that seems need to be checked
I will add new PR for that.
There was a problem hiding this comment.
Oh, I see what you mean about placeholder, seems ok then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.