Skip to content

Use yieldDirectoryExclusivelyWithRelativePathname to allow filter by filename #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Use yieldDirectoryExclusivelyWithRelativePathname to allow filter by filename #2356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73aacab
Use yieldDirectoryExclusivelyWithRelativePathname to allow filter by …
alexander-schranz May 24, 2022
e0ef773
Add number to yield return
alexander-schranz May 25, 2022
b2f61aa
Update AbstractRectorTestCase.php
alexander-schranz May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/Testing/PHPUnit/AbstractRectorTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ protected function tearDown(): void
*/
protected function yieldFilesFromDirectory(string $directory, string $suffix = '*.php.inc'): Iterator
{
return StaticFixtureFinder::yieldDirectoryExclusively($directory, $suffix);
$counter = 0;
foreach (StaticFixtureFinder::yieldDirectoryExclusivelyWithRelativePathname($directory, $suffix) as $name => $parameters) {
yield '#' . $counter . ' ' . $name => $parameters;

++$counter;
}
Comment on lines +97 to +102
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems not working:

vendor/bin/phpunit rules-tests/TypeDeclaration/Rector/ClassMethod/AddArrayReturnDocTypeRector/AddArrayReturnDocTypeRectorTest.php --filter=#1
PHPUnit 9.5.20 #StandWithUkraine

No tests executed!

Copy link
Contributor Author

@alexander-schranz alexander-schranz May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay that is really strange seems like some strange phpunit internal behaviour how # is handled in the filter.

Still thx for your time and feedback.

}

protected function isWindows(): bool
Expand Down