Conditional clearing of finalizers

[scothis]

WithFinalizer's ReadyToClearFinalizer can be used to define custom rules for clearing the finalizer. For example, deletion of a resource can be blocked until all child resources are fully deleted replicating the behavior of an owner reference in parent-child relationships that are not supported by owner references. Client lookups and advanced logic should be avoided as errors cannot be returned. Computed values can be retrieved that were stashed from a previous reconciler, like a SyncReconciler#Finalize hook.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.73%. Comparing base (01b12e7) to head (7d81d03).

Files	Patch %	Lines
reconcilers/finalizer.go	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   59.59%   59.73%   +0.13%     
==========================================
  Files          31       31              
  Lines        2772     2779       +7     
==========================================
+ Hits         1652     1660       +8     
+ Misses       1028     1027       -1     
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mamachanko]

lgtm

[squeedee]

If the inner reconciler deleted some child resources and they're still in "finalize" state, is there a way I can use this hook to observe that without client lookups?

[scothis]

If the inner reconciler deleted some child resources and they're still in "finalize" state, is there a way I can use this hook to observe that without client lookups?

Nope, that info isn't available from calling client.Delete(). You'll need to do the lookup of the resources you care about.

edit: I've considered introducing a side effect to ChildSetReconciler that leaks the current known children into the stash so that a later reconciler could observe them without needing to re-lookup/filter the set. That wouldn't reflect updates/deletes until the next reconcile, but that's probably good enough for your purpose.

[squeedee]

That wouldn't reflect updates/deletes until the next reconcile, but that's probably good enough for your purpose.

I would have cleared the finalizer by then because "nothing went wrong".

[scothis]

That wouldn't reflect updates/deletes until the next reconcile, but that's probably good enough for your purpose.

I would have cleared the finalizer by then because "nothing went wrong".

As is today, yes. With this new hook you can hold on to the finalizer until you're ready to release. Deciding when that is becomes your business logic.