-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests into new categories reviewed by Eric Gamma #1989
Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
5f18cae
Refactor data validation tests
miguelgfierro cd6cc35
Merge branch 'staging' into miguel/new_test_categories
miguelgfierro 5457f50
Changed test_dataset to test_download_utils FYI @looklike
miguelgfierro 1fc7b85
Performance tests
miguelgfierro 2799676
Security tests
miguelgfierro 8b61faf
Security tests
miguelgfierro bb66531
Regression tests
miguelgfierro 7bd6bd7
Regression tests
miguelgfierro e483b62
Criteo responsible AI
miguelgfierro f985b66
Movielens responsible AI
miguelgfierro d6e5dbd
:bug:
miguelgfierro 0ddd3f9
Forgot s
miguelgfierro 46c6ffc
criteo
miguelgfierro 5d3b1ab
criteo
miguelgfierro 79de76f
mind
miguelgfierro abaa152
movielens
miguelgfierro da9dffc
movielens WIP
miguelgfierro 51bca98
movielens
miguelgfierro a42cea0
:bug:
miguelgfierro c243389
integration to functional
miguelgfierro 6b01105
integration to functional
miguelgfierro 64929e7
functional CPU
miguelgfierro 106aee1
functional GPU and Spark
miguelgfierro 1eb3313
Integration
miguelgfierro b9b2a21
Reviewing smoke
miguelgfierro 1a8ab4a
Reviewing smoke
miguelgfierro 3fc4e0d
unit tests notebooks
miguelgfierro 61868d2
unit tests dataset
miguelgfierro dfa0c55
unit python evaluation
miguelgfierro 9498642
unit pyspark evaluation
miguelgfierro 0eea4d8
Added en extra s
miguelgfierro 224e15b
unit models WIP
miguelgfierro 34665b0
unit models WIP
miguelgfierro c26a6a3
unit models
miguelgfierro 66e6dca
unit tuning
miguelgfierro 3cdb4d3
unit utils
miguelgfierro 0fbbec1
:memo:
miguelgfierro c40ffce
:bug:
miguelgfierro de11824
:bug:
miguelgfierro e26f4ff
:bug:
miguelgfierro fdee579
Update readme tests
miguelgfierro 54b171b
License file changed so the maybe download tests had to be updated
miguelgfierro 1c1e1e4
:memo:
miguelgfierro 0d17767
ignoring one of the lightfm for a weird error
miguelgfierro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Regression tests
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
- Loading branch information
commit bb66531c97c6a4c31568c1a8df359d1ee374ee67
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Copyright (c) Recommenders contributors. | ||
# Licensed under the MIT License. | ||
|
||
|
||
import pytest | ||
|
||
|
||
@pytest.mark.gpu | ||
def test_compatibility_tf(): | ||
"""Some of our code uses TF1 and some TF2. Here we just check that we | ||
can import both versions. | ||
""" | ||
import tensorflow as tf | ||
from tensorflow.compat.v1 import placeholder |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe enclose in try - catch and raise
AssertionError
?