Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests into new categories reviewed by Eric Gamma #1989

Merged
merged 44 commits into from
Sep 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
5f18cae
Refactor data validation tests
miguelgfierro Sep 7, 2023
cd6cc35
Merge branch 'staging' into miguel/new_test_categories
miguelgfierro Sep 15, 2023
5457f50
Changed test_dataset to test_download_utils FYI @looklike
miguelgfierro Sep 15, 2023
1fc7b85
Performance tests
miguelgfierro Sep 15, 2023
2799676
Security tests
miguelgfierro Sep 15, 2023
8b61faf
Security tests
miguelgfierro Sep 15, 2023
bb66531
Regression tests
miguelgfierro Sep 15, 2023
7bd6bd7
Regression tests
miguelgfierro Sep 15, 2023
e483b62
Criteo responsible AI
miguelgfierro Sep 15, 2023
f985b66
Movielens responsible AI
miguelgfierro Sep 15, 2023
d6e5dbd
:bug:
miguelgfierro Sep 15, 2023
0ddd3f9
Forgot s
miguelgfierro Sep 15, 2023
46c6ffc
criteo
miguelgfierro Sep 16, 2023
5d3b1ab
criteo
miguelgfierro Sep 16, 2023
79de76f
mind
miguelgfierro Sep 16, 2023
abaa152
movielens
miguelgfierro Sep 16, 2023
da9dffc
movielens WIP
miguelgfierro Sep 16, 2023
51bca98
movielens
miguelgfierro Sep 16, 2023
a42cea0
:bug:
miguelgfierro Sep 16, 2023
c243389
integration to functional
miguelgfierro Sep 16, 2023
6b01105
integration to functional
miguelgfierro Sep 16, 2023
64929e7
functional CPU
miguelgfierro Sep 16, 2023
106aee1
functional GPU and Spark
miguelgfierro Sep 16, 2023
1eb3313
Integration
miguelgfierro Sep 16, 2023
b9b2a21
Reviewing smoke
miguelgfierro Sep 16, 2023
1a8ab4a
Reviewing smoke
miguelgfierro Sep 16, 2023
3fc4e0d
unit tests notebooks
miguelgfierro Sep 16, 2023
61868d2
unit tests dataset
miguelgfierro Sep 16, 2023
dfa0c55
unit python evaluation
miguelgfierro Sep 16, 2023
9498642
unit pyspark evaluation
miguelgfierro Sep 16, 2023
0eea4d8
Added en extra s
miguelgfierro Sep 17, 2023
224e15b
unit models WIP
miguelgfierro Sep 17, 2023
34665b0
unit models WIP
miguelgfierro Sep 17, 2023
c26a6a3
unit models
miguelgfierro Sep 17, 2023
66e6dca
unit tuning
miguelgfierro Sep 17, 2023
3cdb4d3
unit utils
miguelgfierro Sep 17, 2023
0fbbec1
:memo:
miguelgfierro Sep 17, 2023
c40ffce
:bug:
miguelgfierro Sep 17, 2023
de11824
:bug:
miguelgfierro Sep 17, 2023
e26f4ff
:bug:
miguelgfierro Sep 17, 2023
fdee579
Update readme tests
miguelgfierro Sep 17, 2023
54b171b
License file changed so the maybe download tests had to be updated
miguelgfierro Sep 17, 2023
1c1e1e4
:memo:
miguelgfierro Sep 17, 2023
0d17767
ignoring one of the lightfm for a weird error
miguelgfierro Sep 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regression tests
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
  • Loading branch information
miguelgfierro committed Sep 15, 2023
commit bb66531c97c6a4c31568c1a8df359d1ee374ee67
14 changes: 14 additions & 0 deletions tests/regression/test_compatibility_tf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Copyright (c) Recommenders contributors.
# Licensed under the MIT License.


import pytest


@pytest.mark.gpu
def test_compatibility_tf():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe enclose in try - catch and raise AssertionError ?

"""Some of our code uses TF1 and some TF2. Here we just check that we
can import both versions.
"""
import tensorflow as tf
from tensorflow.compat.v1 import placeholder