-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove scipy 1.11.0 to fix the tests #1952
Conversation
@@ -29,7 +29,7 @@ | |||
install_requires = [ | |||
"numpy>=1.19", # 1.19 required by tensorflow 2.6 | |||
"pandas>1.0.3,<2", | |||
"scipy>=1.0.0,<2,!=1.11.0", | |||
"scipy>=1.0.0,<2,!=1.11.0,!=1.11.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better say '<1.11.0' otherwise it will break again when they release 1.11.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the hope that they fix it, in future versions rather than constraining us to <1.11.2. It seems that they didn't really fix the problem in 1.11.1, so they might need to yank it as well o_o
Let's see if the tests pass, I'll contact them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it is a bug though. It could be a feature :-)
Their change probably makes sense because now the symbol is consistent with numpy. Probably we need to switch to the new symbol in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anargyri you are saying that instead of test_scores = self.user_affinity[user_ids, :].dot(self.item_similarity)
we should do test_scores = self.user_affinity[user_ids, :]*self.item_similarity
? so maybe dot is deprecated?
I have raised an issue in Scipy repo: scipy/scipy#18796
Description
Related Issues
Fixes #1951
References
Checklist:
staging branch
and not tomain branch
.