Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support of Python 3.6 in description #1901

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

wutaomsft
Copy link
Collaborator

@wutaomsft wutaomsft commented Mar 25, 2023

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@simonzhaoms
Copy link
Collaborator

simonzhaoms commented Mar 27, 2023

See also #1638. Maybe we should revisit the issue.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@@ -124,7 +124,6 @@
"Topic :: Scientific/Engineering :: Artificial Intelligence",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense, right now we are not testing python 3.6. I'm not sure if all the code works in 3.6

@miguelgfierro miguelgfierro merged commit 6357795 into staging Mar 29, 2023
@miguelgfierro miguelgfierro deleted the wutao/removepy36indesc branch March 29, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants