replacing the reverse iterator approach with forward-indexed loops#546
Open
malik672 wants to merge 1 commit intorecmo:mainfrom
Open
replacing the reverse iterator approach with forward-indexed loops#546malik672 wants to merge 1 commit intorecmo:mainfrom
malik672 wants to merge 1 commit intorecmo:mainfrom
Conversation
Author
|
@prestwich There's no benchmark for this |
Collaborator
|
we should start by adding one then? |
Author
Yes, I did write it but majority of it was prone to CPU noise. So I was like yeah, you should write it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes the
shift_right_smallfunction in the algorithms module by replacing the reverse iterator approach with forward indexed loops.This generates better ASM on both x86 and ARM