Merged
Conversation
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated patch of #1907 as zoom is a very cool feature. The main difference is how I did the transform as the old pull request did not feel right #1907 (comment). The main reason it felt incorrect was that the zooming was done around the center of the screen, instead of the center of the pinch. I honestly did not want to reinvent the postScale function using pure math, so I just used the matrix operations and then extracted translation+scale.
I also fixed some issues with black borders #1907 (comment) and added an outline like youtube.
It should work fine on all horizontal videos, but I have noticed some weird behavior on vertical videos. It is also a bit wonky when zooming in when in the resize option "Zoom" as it instantly zooms out.