Skip to content

support episode alerts for meta providers using next airing #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lephx
Copy link

@lephx lephx commented Apr 2, 2025

No description provided.

@fire-light42
Copy link
Collaborator

Can you please explain in a bit more detail, as I am not sure about the reasoning behind this PR.

  1. What is the problem you are trying to solve?
  2. What the current implementation of subscription does wrong, or lacks?
  3. Why add an additional worker? (EpisodeAlertWorker)

@lephx
Copy link
Author

lephx commented Apr 8, 2025

The current implementation relies on the last seen episode being different from the latest episode to alert users. Meta providers like trakt provide a whole season at once making the latest episode and last seen episode the same throughout preventing alerts.

The pr solves this by using the next airing information provided by the meta provider to schedule an alert using a one-time-request worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants