Skip to content

Fix notebook with null createdAt #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

Fix notebook with null createdAt #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ export function getNotebooks() {
if (!files) return [];
const notebooks = JSON.parse(files).sort((a, b) => new Date(b.updated) - new Date(a.updated));
// Remove fallback runtime when we have breaking changes.
return notebooks.map((notebook) => ({...notebook, runtime: DEFAULT_RUNTIME}));
return notebooks.map((notebook) => {
const newNotebook = {...notebook, runtime: DEFAULT_RUNTIME};
// Add fallback created timestamp.
if (!newNotebook.created) newNotebook.created = new Date().toISOString();
return newNotebook;
});
}

export function clearNotebooksFromLocalStorage() {
Expand Down Expand Up @@ -72,6 +77,10 @@ export function addNotebook(notebook) {
export function saveNotebook(notebook) {
const notebooks = getNotebooks();
const updatedNotebook = {...notebook, updated: new Date().toISOString()};
// Prevent creating a new notebook if the created timestamp is not set.
if (!updatedNotebook.created) {
updatedNotebook.created = new Date().toISOString();
}
const newNotebooks = notebooks.map((f) => (f.id === notebook.id ? updatedNotebook : f));
saveNotebooks(newNotebooks);
}