Repository navigation
0.3.1: keep an avatar URL's query on every request - #1
Merged
Merged
Conversation
loadAvatar("https://host/ani/avatar.json?v=1") used to drop the query from the package's other
files, and a folder URL with a query became ".../ani?v=1/". The package folder now comes from the
URL's path, and the query (a version, a signature) is sent with every request. Found in review of
receptron/mulmocast-cli#1598.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Images cached for ?v=1 were reused for ?v=2; the query is now part of the cache identity. A manifest asset with its own query (rig.json?token=abc) keeps it; the source's query is added only to files without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
snakajima
added a commit
to receptron/mulmocast-cli
that referenced
this pull request
Oct 6, 2026
The source's query is added only to files without one, as avatarscript 0.3.1 does (receptron/avatarscript#1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Codex review (
Tests were added for both. A second Codex review found no actionable issues. The same asset-query rule was applied to receptron/mulmocast-cli#1598's cache stamp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadAvatar()with a URL that has a query used to lose it..../ani/avatar.json?v=1fetched the package's other files without?v=1, and.../ani?v=1became the broken folder.../ani?v=1/.Found in review of receptron/mulmocast-cli#1598, whose cache stamp now keeps the query the same way.
Test plan
avatar.json?v=1loads the same assets as from disk, and every request carriesv=1; a folder URL with?v=2works the same waynpm run lint,npm run typecheck,npm test(57 tests)🤖 Generated with Claude Code
work in mesh-avatar-studio