Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code & codeblocks #1

Merged
merged 6 commits into from
Apr 23, 2023
Merged

Added code & codeblocks #1

merged 6 commits into from
Apr 23, 2023

Conversation

mahdihasnat
Copy link
Collaborator

  • Used Official latest distribution of code
  • Used Universe apt repository for codeblocks & contrib, which serves codeblocks 20.03 currently.

Copy link
Owner

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tested?

scripts/codeblocks.sh Outdated Show resolved Hide resolved
scripts/code.sh Outdated Show resolved Hide resolved
scripts/code.sh Outdated Show resolved Hide resolved
mahdihasnat and others added 2 commits April 21, 2023 23:54
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
@mahdihasnat
Copy link
Collaborator Author

Are these tested?

Worked fine in fresh Ubuntu 22.04. Didn't test on cubic.

Copy link
Owner

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more caveat, sorry. Let's add set -eux in all the scripts from now on.

scripts/code.sh Show resolved Hide resolved
@mahdihasnat
Copy link
Collaborator Author

isn't it same as adding only in install.sh?

@rebornplusplus
Copy link
Owner

Yeah. But if later, I want to change the structure, I want the scripts to be independent by themselves.

mahdihasnat and others added 3 commits April 23, 2023 15:45
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Copy link
Owner

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rebornplusplus rebornplusplus merged commit 6301a67 into master Apr 23, 2023
@rebornplusplus rebornplusplus deleted the feature/code+blocks branch April 23, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants