Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Extend Buffer Lifetime #342

Draft
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

EwanC
Copy link
Collaborator

@EwanC EwanC commented Nov 14, 2023

Ben's WIP work extending the lifetime of buffers used in a graph with buffer::get_access(CGH) when SYCL_GRAPH_EXTEND_BUFFER_LIFETIMES is set.

TODO:

  • Needs tested with a oneDNN example that uses internal scratchpad buffers
  • The assume_buffer_outlives_graph constraint could be relaxed when env var is set

@guoyejun
Copy link

hi, could you share where is the change of the sycl graph spec?

@EwanC
Copy link
Collaborator Author

EwanC commented Apr 30, 2024

hi, could you share where is the change of the sycl graph spec?

Hello, this isn't in the spec yet. This is a proof-of-concept implementation we are wanting to try with some workloads that use buffers internally before advertising in the spec.

It may not be satisfactory by itself as it is only a partial solution - as it only extends the lifetime of buffers when the accessor is created inside the command-group with buffer.get_access(). A full solution to extending buffer lifetimes will also require extending the lifetimes of buffers when the accessor is created outside of the command-group, and then passed in and used with handler::require().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants